On Fri, Aug 29, 2025 at 03:28:35PM -0500, Praveen K Paladugu wrote:
> Update capability schema to include support for hyperv hypervisor with
> qemu domains.
> 
> Signed-off-by: Praveen K Paladugu <[email protected]>
> ---
>  src/conf/schemas/capability.rng | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/conf/schemas/capability.rng b/src/conf/schemas/capability.rng
> index a1606941e7..4d2c1987ae 100644
> --- a/src/conf/schemas/capability.rng
> +++ b/src/conf/schemas/capability.rng
> @@ -432,6 +432,7 @@
>            <value>openvz</value>
>            <value>test</value>
>            <value>hvf</value>
> +          <value>hyperv</value>
>          </choice>
>        </attribute>

Hmm, this is a significant pre-existing bug in libvirt schemas.

The capabilities virt type can emit all the same enum values as
the domain schema virt type. This was missing hyperv, but also
missing countless other types.

Can you take the "hvs" define from domaincommon.rng and move
it into basictypes.rng, renaming it to 'virttype'.

Then you can remove this <choice> and instead use <ref name="virttype"/>
here, as we do from domanicommon.rng.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Reply via email to