On Tue, Oct 14, 2025 at 08:31:43 +0200, Michal Privoznik via Devel wrote: > From: Michal Privoznik <[email protected]> > > Our virNetMessageHeader is a struct that's declared as follows: > > struct virNetMessageHeader { > unsigned prog; > unsigned vers; > int proc; > virNetMessageType type; > unsigned serial; > virNetMessageStatus status; > }; > > Now, per RFC 4506 enums are also encoded as signed integers. This > means, that only 'prog', 'vers' and 'serial' are really unsigned > integers. The others ('proc', 'type' and 'status') are encoded as > signed integers. Fix their type when dissecting.
You don't mention that you are also converting 'guint32' to 'uint32_t'. > > Signed-off-by: Michal Privoznik <[email protected]> > --- > tools/wireshark/src/packet-libvirt.c | 34 +++++++++++++++++++--------- Reviewed-by: Peter Krempa <[email protected]>
