On 10/14/25 19:54, Cole Robinson via Devel wrote:
> Trying to disable <seclabel> for the whole <domain> and _also_
> disable <seclabel> at the <disk> level will fail with:
> 
>   error: unsupported configuration: label overrides require relabeling to be 
> enabled at the domain level
> 
> which seems wrong. Instead skip the validation when disk seclabel
> has relabel='no', that config should always be valid.
> 
> Signed-off-by: Cole Robinson <[email protected]>
> ---
>  src/conf/domain_validate.c                    |  5 +++
>  ...l-selinux-none-override.x86_64-latest.args | 35 +++++++++++++++
>  ...el-selinux-none-override.x86_64-latest.xml | 43 +++++++++++++++++++
>  .../seclabel-selinux-none-override.xml        | 30 +++++++++++++
>  tests/qemuxmlconftest.c                       |  1 +
>  5 files changed, 114 insertions(+)
>  create mode 100644 
> tests/qemuxmlconfdata/seclabel-selinux-none-override.x86_64-latest.args
>  create mode 100644 
> tests/qemuxmlconfdata/seclabel-selinux-none-override.x86_64-latest.xml
>  create mode 100644 tests/qemuxmlconfdata/seclabel-selinux-none-override.xml

Reviewed-by: Michal Privoznik <[email protected]>

Michal

Reply via email to