On Thu, Nov 27, 2025 at 12:52:31 +0530, Arun Menon via Devel wrote: > The new attribute will store the available ciphers with which secrets > can be encrypted. At the moment only aes256cbc encryption method is used. > This can be extended in future. > > Rename the file name structure attribute from base64File to secretValueFile. > > Signed-off-by: Arun Menon <[email protected]> > --- > include/libvirt/libvirt-secret.h | 20 ++++++++++++++++++++ > src/conf/secret_conf.h | 1 + > src/conf/virsecretobj.c | 22 +++++++++++----------- > src/util/virsecret.c | 4 ++++ > src/util/virsecret.h | 1 + > 5 files changed, 37 insertions(+), 11 deletions(-) > > diff --git a/include/libvirt/libvirt-secret.h > b/include/libvirt/libvirt-secret.h > index 761437d4ad..768c92c10c 100644 > --- a/include/libvirt/libvirt-secret.h > +++ b/include/libvirt/libvirt-secret.h > @@ -70,6 +70,26 @@ typedef enum { > # endif > } virSecretUsageType; > > +/** > + * virSecretEncryptionSchemeType: > + * > + * Since: 11.10.0 > + */ > +typedef enum { > + VIR_SECRET_ENCRYPTION_SCHEME_NONE = 0, /* (Since: 11.10.0) */ > + VIR_SECRET_ENCRYPTION_SCHEME_AES256CBC = 1, /* (Since: 11.10.0) */ > +# ifdef VIR_ENUM_SENTINELS > + VIR_SECRET_ENCRYPTION_SCHEME_LAST > + /* > + * NB: this enum value will increase over time as new encryption schemes > are > + * added to the libvirt API. It reflects the last enncryption scheme > supported > + * by this version of the libvirt API. > + * > + * Since: 11.10.0 > + */ > +# endif > +} virSecretEncryptionSchemeType; > +
AFAIU we decided not to expose these constants to the user in any way, but this puts them into the public header file. Also note, that libvirt is in freeze for 11.10.0. So while this part will be deleted and not exposed (thus not requiring version numbers) any other version numbers ought to be updated to 12.0.0.
