Re: [PATCH v2 1/5] qemu: Implement support for associating iommufd to hostdev

[Ján Tomko via Devel]

On a Wednesday in 2025, Nathan Chen wrote:

Hi Jano,

On 12/8/2025 9:58 AM, Ján Tomko wrote:

On a Friday in 2025, Nathan Chen via Devel wrote:

Also, I've applied most of the stuff I say here in my branch,
mostly to see if they are possible:
https://gitlab.com/janotomko/libvirt/-/tree/iommufd?ref_type=heads
git fetch https://gitlab.com/janotomko/libvirt.git iommufd

I have taken parts of your code here for the next revision as they are cleaner than what I came up with. Would it be more correct to put "Signed-off-by: Ján Tomko <jto...@redhat.com>" or "Suggested-by: Ján Tomko <jto...@redhat.com>" preceding my sign-off in the commit descriptions?

Depends on how big the code change is. Personally, I would preserve the
signoff for longer stuff and use "Suggested-by" for shorter changes.

Also, I add my own sign-off when I edit something in a patch before
merging, to indicate that possible errors might not have come from just
the author of the patch, but also could be mine :)

Jano

Thanks,
Nathan

signature.asc
Description: PGP signature