This does not change behavior, but it eliminates direct usage of 'cfg->user' which makes for easier auditing
Signed-off-by: Cole Robinson <[email protected]> --- src/qemu/qemu_process.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 7ebc038e54..a921bbcea8 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -4926,6 +4926,8 @@ qemuPrepareNVRAMFileCommon(virQEMUDriver *driver, g_autoptr(virQEMUDriverConfig) cfg = virQEMUDriverGetConfig(driver); VIR_AUTOCLOSE srcFD = -1; struct qemuPrepareNVRAMHelperData data; + uid_t uid; + gid_t gid; if (!path) return 0; @@ -4951,9 +4953,10 @@ qemuPrepareNVRAMFileCommon(virQEMUDriver *driver, data.srcFD = srcFD; data.srcPath = template; + qemuDomainGetImageIds(cfg, NULL, NULL, NULL, &uid, &gid); if (virFileRewrite(path, S_IRUSR | S_IWUSR, - cfg->user, cfg->group, + uid, gid, qemuPrepareNVRAMHelper, &data) < 0) { return -1; -- 2.53.0
