On Thu, Apr 02, 2026 at 11:12:32 -0400, Cole Robinson via Devel wrote:
> Fixed to abide domain seclabel model='dac' override
> 
> Signed-off-by: Cole Robinson <[email protected]>
> ---
>  src/qemu/qemu_tpm.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/src/qemu/qemu_tpm.c b/src/qemu/qemu_tpm.c
> index 660410bcba..dacceac678 100644
> --- a/src/qemu/qemu_tpm.c
> +++ b/src/qemu/qemu_tpm.c
> @@ -1316,16 +1316,20 @@ qemuExtTPMPrepareHost(virQEMUDriver *driver,
>  {
>      g_autoptr(virQEMUDriverConfig) cfg = virQEMUDriverGetConfig(driver);
>      g_autofree char *shortName = virDomainDefGetShortName(def);
> +    uid_t uid;
> +    gid_t gid;

'gid' is not used

>  
>      if (!shortName)
>          return -1;
>  
> +    qemuDomainGetImageIds(cfg, def, NULL, NULL, &uid, &gid);

and this tolerates any of the last two args being NULL.

> +
>      return qemuTPMEmulatorPrepareHost(tpm,
>                                        cfg->swtpmLogDir,
>                                        cfg->swtpm_user,
>                                        cfg->swtpm_group,
>                                        cfg->swtpmStateDir,
> -                                      cfg->user,
> +                                      uid,
>                                        shortName);
>  }

With 'gid' removed:

Reviewed-by: Peter Krempa <[email protected]>

Reply via email to