On Tue, Apr 07, 2026 at 12:03:36PM +0100, Daniel P. Berrangé via Devel wrote: > On Mon, Apr 06, 2026 at 04:23:25PM +0530, Arun Menon via Devel wrote: > > From: Arun Menon <[email protected]> > > > > The monolithic libvirtd.service currently has a dependency on > > virt-secret-init-encryption.service. This causes libvirtd to fail > > to start on systems where the secret driver is not installed or > > enabled, as systemd cannot satisfy the Requires= unit or the > > LoadCredentialEncrypted= path. See below, > > > > Requires=virt-secret-init-encryption.service > > LoadCredentialEncrypted=secrets-encryption-key:@localstatedir@/lib/libvirt/secrets/secrets-encryption-key > > > > This patch decouples the secrets encryption logic from the main > > libvirtd service file. It is moved into a new systemd drop-in > > (10-secret.conf) which is only installed when libvirt is built > > with secret driver support. The override snippet is added to the > > daemon-driver-secret package. > > > > Fixes: 97758bc9a0b1fccf8c0009308658f1204b113b89 > > Signed-off-by: Arun Menon <[email protected]> > > Fix-Suggested-by: Andrea Bolognani <[email protected]> > > --- > > libvirt.spec.in | 2 ++ > > src/remote/libvirtd.service.in | 4 ---- > > src/remote/meson.build | 15 +++++++++++++++ > > src/remote/secret.conf.in | 7 +++++++ > > Since this is only for libvirtd, can we call it libvirtd-secret.conf.in
I squashed in the change Daniel suggested, added my Reviewed-by: Andrea Bolognani <[email protected]> and pushed the series. Thanks! -- Andrea Bolognani / Red Hat / Virtualization
