From: Peter Krempa <[email protected]> The flag check inside 'qemuDomainGetSEVInfo' makes no sense because it only validates the 'VIR_TYPED_PARAM_STRING_OKAY' which is not actually used.
Remove the 'flags parameter from 'qemuDomainGetSEVInfo' and validate flags at 'qemuDomainGetLaunchSecurityInfo' Signed-off-by: Peter Krempa <[email protected]> --- src/qemu/qemu_driver.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index a2b5959e55..781efd612c 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -19668,16 +19668,13 @@ qemuNodeGetSEVInfo(virConnectPtr conn, static int qemuDomainGetSEVInfo(virDomainObj *vm, - virTypedParamList *list, - unsigned int flags) + virTypedParamList *list) { int ret = -1; int rv; g_autofree char *tmp = NULL; qemuMonitorSEVInfo info = { }; - virCheckFlags(VIR_TYPED_PARAM_STRING_OKAY, -1); - if (virDomainObjBeginJob(vm, VIR_JOB_QUERY) < 0) return -1; @@ -19737,6 +19734,8 @@ qemuDomainGetLaunchSecurityInfo(virDomainPtr domain, virDomainObj *vm; int ret = -1; + virCheckFlags(VIR_TYPED_PARAM_STRING_OKAY, -1); + if (!(vm = qemuDomainObjFromDomain(domain))) goto cleanup; @@ -19751,7 +19750,7 @@ qemuDomainGetLaunchSecurityInfo(virDomainPtr domain, switch (vm->def->sec->sectype) { case VIR_DOMAIN_LAUNCH_SECURITY_SEV: case VIR_DOMAIN_LAUNCH_SECURITY_SEV_SNP: - if (qemuDomainGetSEVInfo(vm, list, flags) < 0) + if (qemuDomainGetSEVInfo(vm, list) < 0) goto cleanup; break; case VIR_DOMAIN_LAUNCH_SECURITY_PV: -- 2.54.0
