From: Peter Krempa <[email protected]> The implementation for managed save uses 'qemuDomainSaveImageDefineXML' internally which validates the flags. To have a top level flag validation for the upcoming flag introspection export the supported flags as a macro and add a 'virCheckFlags' to 'qemuDomainManagedSaveDefineXML'.
Signed-off-by: Peter Krempa <[email protected]> --- src/qemu/qemu_driver.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 8e30857b34..34d8f0257d 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -6120,6 +6120,11 @@ qemuDomainSaveImageGetXMLDesc(virConnectPtr conn, const char *path, return ret; } + +#define QEMU_SAVE_IMAGE_DEFINE_FLAGS \ + VIR_DOMAIN_SAVE_RUNNING | \ + VIR_DOMAIN_SAVE_PAUSED + static int qemuDomainSaveImageDefineXML(virConnectPtr conn, const char *path, const char *dxml, unsigned int flags) @@ -6132,8 +6137,7 @@ qemuDomainSaveImageDefineXML(virConnectPtr conn, const char *path, virQEMUSaveData *data = NULL; int state = -1; - virCheckFlags(VIR_DOMAIN_SAVE_RUNNING | - VIR_DOMAIN_SAVE_PAUSED, -1); + virCheckFlags(QEMU_SAVE_IMAGE_DEFINE_FLAGS, -1); if (flags & VIR_DOMAIN_SAVE_RUNNING) state = 1; @@ -6243,6 +6247,8 @@ qemuDomainManagedSaveDefineXML(virDomainPtr dom, const char *dxml, g_autofree char *path = NULL; int ret = -1; + virCheckFlags(QEMU_SAVE_IMAGE_DEFINE_FLAGS, -1); + if (!(vm = qemuDomainObjFromDomain(dom))) return -1; -- 2.54.0
