On Wed, Jul 01, 2026 at 09:27:12AM +0200, Markus Armbruster wrote:
> Daniel P. Berrangé <[email protected]> writes:
> 
> > Add new docs for the `-object monitor-hmp` and `-object monitor-qmp`
> > options, updating `-mon` to state that it is legacy syntax sugar
> > for the new `-object` args.
> >
> > Reviewed-by: Marc-André Lureau <[email protected]>
> > Tested-by: Peter Krempa <[email protected]>
> > Signed-off-by: Daniel P. Berrangé <[email protected]>
> > ---
> >  qemu-options.hx | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 49 insertions(+)
> >
> > diff --git a/qemu-options.hx b/qemu-options.hx
> > index c799286153..a804d5b880 100644
> > --- a/qemu-options.hx
> > +++ b/qemu-options.hx
> > @@ -4980,6 +4980,16 @@ SRST
> >        -mon chardev=mon1,mode=control,pretty=on
> >  
> >      enables the QMP monitor on localhost port 4444 with pretty-printing.
> > +
> > +    The use of ``-mon mode=readline`` is historical syntax sugar
> > +    for the new ``-object monitor-hmp`` option, each use of which
> > +    creates an object with the ID ``hmpcompatNNN`` where ``NNN`` is
> > +    a counter starting from 0.
> > +
> > +    The use of ``-mon mode=control`` is historical syntax sugar
> > +    for the new ``-object monitor-qmp`` option, each use of which
> > +    creates an object with the ID ``qmpcompatNNN`` where ``NNN`` is
> > +    a counter starting from 0.
> >  ERST
> 
> Should we document how -monitor, -qmp, and -qmp-pretty map to -object
> and -chardev?

I thought they already described how they were mapped to -mon,
but I see I was mistaken. It is worth a followup patch to
improve their docs, especially given your points around the
implicit "id" value they have internally.

With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|

Reply via email to