On Tue, Aug 18, 2026 at 05:16:33PM +0200, Peter Krempa via Devel wrote:
> From: Peter Krempa <[email protected]>
> 
> Preserve the error on cleanup path as cleanup of the 'libivrt_iohelper'

s/libivrt_iohelper/libvirt_iohelper/

> process may overwrite it with an unactionable error, such as when
> attempting to restore a save image while the VM is already running:
> 
>   $ virsh list
>    Id   Name       State
>   --------------------------
>    9    cd         running
> 
>   $ virsh restore /tmp/cd.save
>   error: Failed to restore domain from /tmp/cd.save
>   error: internal error: Child process (LIBVIRT_LOG_OUTPUTS=1:stderr 
> /home/pipo/build/libvirt/gcc/src/libvirt_iohelper /tmp/cd.save 0) unexpected 
> fatal signal 13
> 
> After this patch the original error is reported:
> 
>   $ virsh restore /tmp/cd.save
>   error: Failed to restore domain from /tmp/cd.save
>   error: Requested operation is not valid: domain 'cd' is already active
> 
> Signed-off-by: Peter Krempa <[email protected]>
> ---
>  src/qemu/qemu_driver.c | 3 +++
>  1 file changed, 3 insertions(+)

Reviewed-by: Pavel Hrdina <[email protected]>

Attachment: signature.asc
Description: PGP signature

Reply via email to