On Sat, Aug 01, 2026 at 12:04:23 -0500, Jaehoon Kim wrote: > Wire the poll-weight setting into the QEMU command line, monitor, and > driver-side parameter handling. > > Add poll-weight to the iothread object properties when building the > QEMU command line. Add the live setter in the monitor JSON layer using > a new VIR_IOTHREAD_SET_PROP_UINT macro consistent with the existing UL > variant. Wire up typed parameter parsing with an explicit range check > for [0, 63] and propagate the value into the persistent domain > definition on hotplug. Guard the live path with a capability check. > > Add a CAPS check in the domain validator and remove the now-unnecessary > break from the thread pool validation loop since the loop must continue > to check poll-weight on every iothread. > > Also add VIR_DOMAIN_IOTHREAD_POLL_WEIGHT typed parameter constant and > a qemuxmlconf test case for the new functionality. > > Signed-off-by: Jaehoon Kim <[email protected]> > --- > include/libvirt/libvirt-domain.h | 15 +++++ > src/qemu/qemu_command.c | 6 ++ > src/qemu/qemu_driver.c | 33 +++++++++++ > src/qemu/qemu_monitor_json.c | 13 +++++ > src/qemu/qemu_validate.c | 10 +++- > ...s-poll-weight-outofrange.x86_64-latest.err | 1 + > .../iothreads-ids-poll-weight-outofrange.xml | 58 +++++++++++++++++++ > ...threads-ids-poll-weight.x86_64-latest.args | 40 +++++++++++++ > ...othreads-ids-poll-weight.x86_64-latest.xml | 58 +++++++++++++++++++ > .../iothreads-ids-poll-weight.xml | 58 +++++++++++++++++++ > tests/qemuxmlconftest.c | 2 + > 11 files changed, 292 insertions(+), 2 deletions(-) > create mode 100644 > tests/qemuxmlconfdata/iothreads-ids-poll-weight-outofrange.x86_64-latest.err > create mode 100644 > tests/qemuxmlconfdata/iothreads-ids-poll-weight-outofrange.xml > create mode 100644 > tests/qemuxmlconfdata/iothreads-ids-poll-weight.x86_64-latest.args > create mode 100644 > tests/qemuxmlconfdata/iothreads-ids-poll-weight.x86_64-latest.xml > create mode 100644 tests/qemuxmlconfdata/iothreads-ids-poll-weight.xml
Reviewed-by: Peter Krempa <[email protected]>
