Hmmm...I'm afraid I cannot entirely substantiate your concerns. Everything compiles just fine for me under both Linux and OSX. True, the files are not completely instantiated on the trunk at this time, but they also are not activated on the trunk for precisely that reason.

Can you provide an example of where something isn't building? I can't find it on any platform available to me.

Thanks
Ralph

On Aug 20, 2009, at 4:32 PM, George Bosilca wrote:

Ralph,

I'm a little bit concerned about the commits stated below as their quality doesn't match the usual quality standards of the trunk. There are several issues: mostly empty files, names coming from other frameworks, failure to compile on several platforms (including Linux and MAC OS X). I'm more than happy to see research code in the trunk, and I will be really interested to see the proof that preemptive migration works. However, the quality of the trunk should not suffer.

Moreover, we have mercurial and svn temporary repositories for such kind of work. And we did force people in the past to work on temporary branches before such large commits on the trunk.

Please reconsider your patches.

 Thanks,
   george.



https://svn.open-mpi.org/trac/ompi/changeset/21849
https://svn.open-mpi.org/trac/ompi/changeset/21850
https://svn.open-mpi.org/trac/ompi/changeset/21848
https://svn.open-mpi.org/trac/ompi/changeset/21847

_______________________________________________
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel

Reply via email to