On Feb 27, 2014, at 6:58 AM, Jeff Squyres (jsquyres) <jsquy...@cisco.com> wrote:
> On Feb 27, 2014, at 3:33 AM, George Bosilca <bosi...@icl.utk.edu> wrote: > >> I’m concerned about your usage of abort here. Looking at the code I noticed >> that you call RTE_ABORT deep inside the BTL stack. This is a significant >> divergence from our current behavior (except for USNIC apparently as the >> code is now in the 1.7). The BTLs are not deciders, but merely reporters. >> Any error should be reported upstream, and will be dealt with at that level. > > The majority of places we call abort in this commit is actually down in a > progress thread. We didn't think it was safe to call the PML error function > in a progress thread -- is that incorrect? If not, then we probably should create some mechanism for doing so. I agree with George that we shouldn't call abort inside a library > > -- > Jeff Squyres > jsquy...@cisco.com > For corporate legal information go to: > http://www.cisco.com/web/about/doing_business/legal/cri/ > > _______________________________________________ > devel mailing list > de...@open-mpi.org > http://www.open-mpi.org/mailman/listinfo.cgi/devel