Nathan, do you mean the bug/typo was not at line 487 (e.g. btl_send was ok) but at line 498 ? (e.g. btl_send must be used instead of btl_eager)
at first sight, that make sense. i'd rather let the author/maintainer of this part comment on that Cheers, Gilles On Sat, May 17, 2014 at 5:47 AM, Hjelm, Nathan T <hje...@lanl.gov> wrote: > Is this correct? Shouldn't the fix be to change the call before the loop > to reference btl_send instead of btl_eager? > > I ask because it looks like the loop is trying to prevent a btl from > getting del_procs twice for the same proc. If we do not remove the btl from > the btl_send array it will get the call twice. > > Correct me if I am wrong. > > -Nathan > > ________________________________________ > From: svn [svn-boun...@open-mpi.org] on behalf of > svn-commit-mai...@open-mpi.org [svn-commit-mai...@open-mpi.org] > Sent: Thursday, May 15, 2014 10:43 PM > To: s...@open-mpi.org > Subject: [OMPI svn] svn:open-mpi r31786 - trunk/ompi/mca/bml/r2 > > Author: ggouaillardet (Gilles Gouaillardet) > Date: 2014-05-16 00:43:18 EDT (Fri, 16 May 2014) > New Revision: 31786 > URL: https://svn.open-mpi.org/trac/ompi/changeset/31786 > > Log: > Fix a typo in mca_bml_r2_del_procs() > > Use bml_endpoint->btl_eager instead of bml_endpoint->btl_send. > > cmr=v1.8.2:reviewer=rhc > > Text files modified: > trunk/ompi/mca/bml/r2/bml_r2.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > Modified: trunk/ompi/mca/bml/r2/bml_r2.c > > ============================================================================== > --- trunk/ompi/mca/bml/r2/bml_r2.c Thu May 15 20:30:41 2014 > (r31785) > +++ trunk/ompi/mca/bml/r2/bml_r2.c 2014-05-16 00:43:18 EDT (Fri, 16 > May 2014) (r31786) > @@ -15,6 +15,8 @@ > * Copyright (c) 2008-2014 Cisco Systems, Inc. All rights reserved. > * Copyright (c) 2013 Intel, Inc. All rights reserved > * Copyright (c) 2014 NVIDIA Corporation. All rights reserved. > + * Copyright (c) 2014 Research Organization for Information Science > + * and Technology (RIST). All rights reserved. > * $COPYRIGHT$ > * > * Additional copyrights may follow > @@ -482,7 +484,7 @@ > */ > n_size = > mca_bml_base_btl_array_get_size(&bml_endpoint->btl_eager); > for(n_index = 0; n_index < n_size; n_index++) { > - mca_bml_base_btl_t* search_bml_btl = > mca_bml_base_btl_array_get_index(&bml_endpoint->btl_send, n_index); > + mca_bml_base_btl_t* search_bml_btl = > mca_bml_base_btl_array_get_index(&bml_endpoint->btl_eager, n_index); > if(search_bml_btl->btl == btl) { > memset(search_bml_btl, 0, sizeof(mca_bml_base_btl_t)); > break; > _______________________________________________ > svn mailing list > s...@open-mpi.org > http://www.open-mpi.org/mailman/listinfo.cgi/svn > _______________________________________________ > devel mailing list > de...@open-mpi.org > Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel > Link to this post: > http://www.open-mpi.org/community/lists/devel/2014/05/14821.php >
