On Dec 18, 2014, at 3:13 AM, Gilles Gouaillardet <gilles.gouaillar...@iferc.org> wrote:
> currently, ompi master cannot be built if configured with > --without-hwloc *and without* --without-libfabric. > > the root cause is HAVE_CONFIG_H is defined but no config.h file is found. > > i digged a bit and found that config.h is taken from a hwloc directory > (if the --without-hwloc option is not used), > so even if this "works" that is unlikely the expected behavior. Mmm. I see what you're saying -- the libfabric code expects there to be a config.h file; it'll basically take any config.h that's in the include path. I actually find several config.h's in the tree: ----- $ find . -name config.h ./opal/libltdl/config.h ./opal/mca/hwloc/hwloc191/hwloc/include/hwloc/autogen/config.h ./opal/mca/hwloc/hwloc191/hwloc/include/private/autogen/config.h ./opal/mca/event/libevent2021/libevent/config.h ./ompi/contrib/vt/vt/extlib/otf/config.h ./ompi/contrib/vt/vt/config.h ----- However, even if I exclude libltdl, vt, and hwloc (so that there's only a single config.h left in the tree -- for libevent), everything still works: ---- $ ./configure --prefix=$bogus --disable-dlopen --disable-vt --without-hwloc ...etc... $ make [...succeeds...] $ find . -name config.h ./opal/mca/event/libevent2021/libevent/config.h ----- So I agree with you that it only works by chance (sorta -- libevent's config.h will still have all the Right Stuff in it), I can't find a case that fails. Can you detail what your specific case is that is failing? (SIDENOTE: I might not be able to find the failure because of what I mention below...) > the attached patch fixes some missing #ifdef Good catch. I fixed those a different way (just deleted the #includes -- they weren't necessary); I committed the fix both in OMPI and upstream in libfabric. > my last (cosmetic) comment is about > $srcdir/opal/mca/common/libfabric/Makefile.in (and several other > Makefile.in) : > [snipped] Good catch. Fixed in https://github.com/open-mpi/ompi/commit/be6d46490f7b80d4f5ea90c859ccbebe96bdaaba. And then later fixed *that* a followup commit. :-( -- Jeff Squyres jsquy...@cisco.com For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/
