I confirm this is now fixed. Thanks. George.
On Sat, Dec 20, 2014 at 12:46 PM, Ralph Castain <r...@open-mpi.org> wrote: > Works for me…thanks! > > On Dec 20, 2014, at 9:37 AM, Jeff Squyres (jsquyres) <jsquy...@cisco.com> > wrote: > > Fixed. > > -- > > Jeff Squyres > > jsquy...@cisco.com > > For corporate legal information go to: > http://www.cisco.com/web/about/doing_business/legal/cri/ > ------------------------------ > *From:* devel [devel-boun...@open-mpi.org] on behalf of George Bosilca [ > bosi...@icl.utk.edu] > *Sent:* Saturday, December 20, 2014 12:56 AM > *To:* Open MPI Developers > *Subject:* Re: [OMPI devel] libfabric, config.h and hwloc > > The trunk is broken: > > libfabric/libfabric/include/fi.h:50:25: error: stdatomic.h: No such file > or directory > > George. > > > > On Fri, Dec 19, 2014 at 2:03 AM, Gilles Gouaillardet < > gilles.gouaillar...@iferc.org> wrote: > >> Jeff, >> >> the include path is $top_srcdir/opal/mca/event/libevent2021/libevent >> and the libevent config.h is in >> $top_builddir/opal/mca/event/libevent2021/libevent >> >> so if you do not use VPATH, $top_srcdir = $top_builddir and make success, >> but since i use VPATH, $top_srcdir != $top_builddir and there is no >> config.h in my include path, >> and hence make fails. >> >> Cheers, >> >> Gilles >> >> >> >> On 2014/12/19 4:12, Jeff Squyres (jsquyres) wrote: >> > On Dec 18, 2014, at 3:13 AM, Gilles Gouaillardet < >> gilles.gouaillar...@iferc.org> wrote: >> > >> >> currently, ompi master cannot be built if configured with >> >> --without-hwloc *and without* --without-libfabric. >> >> >> >> the root cause is HAVE_CONFIG_H is defined but no config.h file is >> found. >> >> >> >> i digged a bit and found that config.h is taken from a hwloc directory >> >> (if the --without-hwloc option is not used), >> >> so even if this "works" that is unlikely the expected behavior. >> > Mmm. I see what you're saying -- the libfabric code expects there to >> be a config.h file; it'll basically take any config.h that's in the include >> path. >> > >> > I actually find several config.h's in the tree: >> > >> > ----- >> > $ find . -name config.h >> > ./opal/libltdl/config.h >> > ./opal/mca/hwloc/hwloc191/hwloc/include/hwloc/autogen/config.h >> > ./opal/mca/hwloc/hwloc191/hwloc/include/private/autogen/config.h >> > ./opal/mca/event/libevent2021/libevent/config.h >> > ./ompi/contrib/vt/vt/extlib/otf/config.h >> > ./ompi/contrib/vt/vt/config.h >> > ----- >> > >> > However, even if I exclude libltdl, vt, and hwloc (so that there's only >> a single config.h left in the tree -- for libevent), everything still works: >> > >> > ---- >> > $ ./configure --prefix=$bogus --disable-dlopen --disable-vt >> --without-hwloc >> > ...etc... >> > $ make >> > [...succeeds...] >> > $ find . -name config.h >> > ./opal/mca/event/libevent2021/libevent/config.h >> > ----- >> > >> > So I agree with you that it only works by chance (sorta -- libevent's >> config.h will still have all the Right Stuff in it), I can't find a case >> that fails. >> > >> > Can you detail what your specific case is that is failing? >> > >> > (SIDENOTE: I might not be able to find the failure because of what I >> mention below...) >> > >> >> the attached patch fixes some missing #ifdef >> > Good catch. I fixed those a different way (just deleted the #includes >> -- they weren't necessary); I committed the fix both in OMPI and upstream >> in libfabric. >> > >> >> my last (cosmetic) comment is about >> >> $srcdir/opal/mca/common/libfabric/Makefile.in (and several other >> >> Makefile.in) : >> >> [snipped] >> > Good catch. Fixed in >> https://github.com/open-mpi/ompi/commit/be6d46490f7b80d4f5ea90c859ccbebe96bdaaba. >> And then later fixed *that* a followup commit. :-( >> > >> >> _______________________________________________ >> devel mailing list >> de...@open-mpi.org >> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel >> Link to this post: >> http://www.open-mpi.org/community/lists/devel/2014/12/16684.php >> > > _______________________________________________ > devel mailing list > de...@open-mpi.org > Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel > Link to this post: > http://www.open-mpi.org/community/lists/devel/2014/12/16706.php > > > > _______________________________________________ > devel mailing list > de...@open-mpi.org > Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel > Link to this post: > http://www.open-mpi.org/community/lists/devel/2014/12/16707.php >
