On May 19, 2015, at 12:36 PM, Ralph Castain <rhc.open...@gmail.com> wrote:
> Our pr tests aren't good enough for what you propose I made no claim about whether PRs even needed automated testing in order to switch to this scheme. Right now I could push any old garbage I want into the master directly without ever using a PR, without ever having had a code review, and without having had any sort of testing. Automated PR testing is a separate issue and would be pure gravy here. The change would be whether or not it's OK to have some additional delay from the time a contributor decides a patch set is acceptable for inclusion in OMPI's master branch until the time that someone else with push access merges the PR. It also requires that everyone is OK with having some limited set of people who can make those pull decisions. IMO, both are fine. Others may disagree. Alternatively, a half version of this would be to collapse to a single repository where only the release branch maintainers have direct push access, but allow PRs against master to be automatically merged by anyone by using the OMPIbot (with a "bot:pullme" comment or whatever). -Dave
