On Wednesday 03 September 2008 18:26 Cedric Le Goater wrote: > > Forgot a global comment: you will probably get the same (rather pointless > > for a proof of concept, IMHO) requests as Oren got, to > > 1) improve coding style: > > a) especially avoid error handling like: > > err = foo(); > > if (!err) > > err = bar(); > > if (!err) > > err = baz(); > > > > and prefer > > err = foo(); > > if (err) > > goto foo_err; > > err = bar(); > > ... > > > > b) do not write conditions on a single line, like > > if (foo) bar; > > > > 2) put arch-dependent code in arch/ subdirs. > > 3) I probably forgot other ones. > > ./scripts/checkpatch.pl catches most of it (and it does catch a few on your > patches)
Thanks, I will use this script to brush up the code. > > but Dave is even better ! :) I'm waiting for his comments :) Regards, Andrey > > > I obviously do not personally request you to take these requests into > > account ;) > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ _______________________________________________ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _______________________________________________ Devel mailing list Devel@openvz.org https://openvz.org/mailman/listinfo/devel
