Hi Kaspar, On 11.09.2017 09:01, Kaspar Schleiser wrote:
> Only mips-malta has it's own "pm_reboot()" implementation. The other two > define stubs. Might be, still, it has to be considered where to place it and how we define fallbacks cleanly! >> Additionally pm_layered does not define pm_reboot, the same applies for >> pm_off (pm_off can be modeled as pm_set_lowest(); irq_disable(); >> while(1) in pm_layered I guess ?). > > pm_layered does define pm_set_lowest() as weak exactly like that. I am not using weak definitions. Because of the PR that claims that definitions are not chosen correctly in RIOT! > >> Therefore I will work on removing pm_reboot() from pm_fallback >> implementation and create additional modules if needed (at some points >> pm_reboot is defined outside of pm anyway). > > When designing periph/pm, we intentionally moved reboot from a core > include into periph/pm, as it seemed to fit together with pm_off(). Can't really see a reason why this belongs together IMO, but we can leave it there for now. > Do you have a WIP branch somewhere? While working on #7241, I had to > implement a lot of what we've discussed, in order to make anything > compile with sumbodulized periph. Maybe you can take a look? the > requirements have changed a little. I stopped working on this because of the pm_reboot problems. Therefore I didnt create a WIP branch on my fork yet, as I wasn't able to setup a working version. Your PR does not compile for me, almost 50% of the boards in examples/default/ are not compiling anymore. At least the first few I checked are missing pm_reboot (undefined reference). - Robert -- Robert Hartung, M.Sc. Technische Universität Braunschweig Institut für Betriebssysteme und Rechnerverbund Mühlenpfordtstr. 23, Raum 115 38106 Braunschweig Fon: +49 (531) 391 - 3264 Fax: +49 (531) 391 - 5936 E-Mail: hart...@ibr.cs.tu-bs.de _______________________________________________ devel mailing list devel@riot-os.org https://lists.riot-os.org/mailman/listinfo/devel
