Hi, On Sun, Aug 8, 2021 at 3:00 PM Christian Mauderer <o...@c-mauderer.de> wrote:
> Hello Husni, > > On 08/08/2021 11:15, Ahamed Husni wrote: > > Hi Christian, > > > > On Sun, Aug 8, 2021 at 1:36 PM Christian Mauderer <o...@c-mauderer.de > > <mailto:o...@c-mauderer.de>> wrote: > > > > Hello Husni, > > > > On 07/08/2021 21:56, Ahamed Husni wrote: > > > Hi Christian, > > > > > > Are there any issues I should address in this patch set? > > > > I think the big open question is the one from Chris: > > > > https://lists.rtems.org/pipermail/devel/2021-July/068634.html > > <https://lists.rtems.org/pipermail/devel/2021-July/068634.html> > > > > You mentioned that you filtered the ones for the imported code. > That's > > OK for most symbols if they are not relevant for the part where you > > work > > on. But Chris copied a whole block of "extern struct > > usb_temp_device_desc *". It's not clear for me whether you filtered > > some > > of them or whether they haven't been generated. > > > > The "extern struct usb_temp_device_desc *" block is in the > > usb_template.h header. > > These are not generated structs. > > These usb device descriptor structs are for each usb device currently > > supported by > > freebsd. This patch set only imports the CDC Ethernet device template. > > So we can > > exclude the other structs with #ifndef __rtems__ if necessary. If the > > extra structs should > > be excluded, I can send a patch v3. > > > > If they are generated: Please keep them. Basically keep everything > that > > is in one of the files that you touch, except if you have a good > reason > > why the symbol should _not_ be added. > > > > If they are not generated: Please clearly say that. > > > > Those externs are not generated. They are in the original freebsd source. > > > https://github.com/freebsd/freebsd-src/blob/main/sys/dev/usb/template/usb_template.h#L106 > > < > https://github.com/freebsd/freebsd-src/blob/main/sys/dev/usb/template/usb_template.h#L106 > > > > What I wanted to say was: If the defines like > > #define usb_template_cdce _bsd_usb_template_cdce > > are not generated for the other externa that Chris listed, please say > it. I just checked and they are not. So I'm OK with that. > > ah yes. defines for other structs didn't generate. I misunderstood the question earlier. Sorry. > So if I have followed the discussion correctly, there are no further > changes (except for the typo in one file), correct? > > yes. The branches usb-cdce and usb-cdce12 are up to date? > > yes. (the typo is not fixed there either.) Best regards, Husni. Best regards > > Christian > > > > > Best regards, > > Husni. > > > > Best regards > > > > Christian > > > > > > > > On Mon, Aug 2, 2021 at 12:09 PM Christian MAUDERER > > > <christian.maude...@embedded-brains.de > > <mailto:christian.maude...@embedded-brains.de> > > > <mailto:christian.maude...@embedded-brains.de > > <mailto:christian.maude...@embedded-brains.de>>> wrote: > > > > > > Hello Husni, > > > > > > Am 01.08.21 um 19:59 schrieb Ahamed Husni: > > > > Hi Christian, > > > > > > > > On Sun, Aug 1, 2021 at 4:57 PM Christian Mauderer > > > <o...@c-mauderer.de <mailto:o...@c-mauderer.de> > > <mailto:o...@c-mauderer.de <mailto:o...@c-mauderer.de>> > > > > <mailto:o...@c-mauderer.de <mailto:o...@c-mauderer.de> > > <mailto:o...@c-mauderer.de <mailto:o...@c-mauderer.de>>>> wrote: > > > > > > > > Hello Husni, > > > > > > > > just tested that and it works fine. With a simple curl > > I can > > > reach > > > > about > > > > 8.5 MByte/s sending to the beagle and 19.5 MByte/s > > receiving > > > from it. > > > > > > > > That's 68 Mbps for sending. That's an acceptable speed > > isn't it? > > > > > > > > > > At the moment I would be OK with basically any speed. It was > > just some > > > information so that someone who finds the mail knows what he > > can expect. > > > > > > It would be interesting to see how the speeds compare to a > > FreeBSD > > > setup > > > on the Beagle. If there is no bug in our port, it should be > about > > > the same. > > > > > > Best regards > > > > > > Christian > > > > > > > Please take a look at the points that Chris Johns > > asked. As > > > soon as > > > > these are addressed, I think the patches could be > merged. > > > > > > > > I just replied to it now. Sorry for the delay. > > > > > > > > > > > > Please also make the documentation that you started > > for this more > > > > public > > > > visible. In other words: Send it as patches to the > > list and > > > not only as > > > > a link to some branch! > > > > > > > > Noted. > > > > > > > > > > > > Best regards > > > > > > > > Christian > > > > > > > > On 28/07/2021 13:56, Husni Faiz wrote: > > > > > This set of patches import the drivers from freebsd > and > > > > > configures it for the beagle bsp. > > > > > > > > > > Github Branch for the commits > > > > > > > https://github.com/drac98/rtems-libbsd/commits/usb-cdce > > <https://github.com/drac98/rtems-libbsd/commits/usb-cdce> > > > <https://github.com/drac98/rtems-libbsd/commits/usb-cdce > > <https://github.com/drac98/rtems-libbsd/commits/usb-cdce>> > > > > > > <https://github.com/drac98/rtems-libbsd/commits/usb-cdce > > <https://github.com/drac98/rtems-libbsd/commits/usb-cdce> > > > <https://github.com/drac98/rtems-libbsd/commits/usb-cdce > > <https://github.com/drac98/rtems-libbsd/commits/usb-cdce>>> > > > > > > > > > > Patch for 6-freebsd-12 branch > > > > > > > https://github.com/drac98/rtems-libbsd/commits/usb-cdce12 > > <https://github.com/drac98/rtems-libbsd/commits/usb-cdce12> > > > <https://github.com/drac98/rtems-libbsd/commits/usb-cdce12 > > <https://github.com/drac98/rtems-libbsd/commits/usb-cdce12>> > > > > > > <https://github.com/drac98/rtems-libbsd/commits/usb-cdce12 > > <https://github.com/drac98/rtems-libbsd/commits/usb-cdce12> > > > <https://github.com/drac98/rtems-libbsd/commits/usb-cdce12 > > <https://github.com/drac98/rtems-libbsd/commits/usb-cdce12>>> > > > > > > > > > > Husni Faiz (5): > > > > > usb_template:Import CDC Ethernet > > > > > usb_template: Configure template driver only for > CDC > > > Ethernet > > > > > nexus-devices: Include CDC Ethernet for Beagle > > > > > libbsd.py: add usb template files > > > > > create-kernel-namespace for USB Template driver > > > > > > > > > > buildset/default.ini | > > 1 + > > > > > buildset/minimal.ini | > > 3 +- > > > > > freebsd/sys/dev/usb/template/usb_template.c | > 1493 > > > > +++++++++++++++++ > > > > > freebsd/sys/dev/usb/template/usb_template.h | > > 130 ++ > > > > > .../sys/dev/usb/template/usb_template_cdce.c | > > 355 ++++ > > > > > freebsd/sys/dev/usb/usb_device.c | > > 8 +- > > > > > libbsd.py | > > 25 + > > > > > rtemsbsd/include/bsp/nexus-devices.h | > > 5 + > > > > > .../machine/rtems-bsd-kernel-namespace.h | > > 5 + > > > > > .../include/machine/rtems-bsd-nexus-bus.h | > > 19 + > > > > > 10 files changed, 2041 insertions(+), 3 > deletions(-) > > > > > create mode 100644 > > > freebsd/sys/dev/usb/template/usb_template.c > > > > > create mode 100644 > > > freebsd/sys/dev/usb/template/usb_template.h > > > > > create mode 100644 > > > freebsd/sys/dev/usb/template/usb_template_cdce.c > > > > > > > > > > > > > > > > > _______________________________________________ > > > > devel mailing list > > > > devel@rtems.org <mailto:devel@rtems.org> > > <mailto:devel@rtems.org <mailto:devel@rtems.org>> > > > > http://lists.rtems.org/mailman/listinfo/devel > > <http://lists.rtems.org/mailman/listinfo/devel> > > > <http://lists.rtems.org/mailman/listinfo/devel > > <http://lists.rtems.org/mailman/listinfo/devel>> > > > > > > > > > > -- > > > -------------------------------------------- > > > embedded brains GmbH > > > Herr Christian MAUDERER > > > Dornierstr. 4 > > > 82178 Puchheim > > > Germany > > > email: christian.maude...@embedded-brains.de > > <mailto:christian.maude...@embedded-brains.de> > > > <mailto:christian.maude...@embedded-brains.de > > <mailto:christian.maude...@embedded-brains.de>> > > > phone: +49-89-18 94 741 - 18 > > > fax: +49-89-18 94 741 - 08 > > > > > > Registergericht: Amtsgericht München > > > Registernummer: HRB 157899 > > > Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, > > Thomas Dörfler > > > Unsere Datenschutzerklärung finden Sie hier: > > > https://embedded-brains.de/datenschutzerklaerung/ > > <https://embedded-brains.de/datenschutzerklaerung/> > > > <https://embedded-brains.de/datenschutzerklaerung/ > > <https://embedded-brains.de/datenschutzerklaerung/>> > > > > > > > > >
_______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
