On 8/8/21 6:06 pm, Christian Mauderer wrote: > Hello Husni, > > On 07/08/2021 21:56, Ahamed Husni wrote: >> Hi Christian, >> >> Are there any issues I should address in this patch set? > > I think the big open question is the one from Chris: > > https://lists.rtems.org/pipermail/devel/2021-July/068634.html > > You mentioned that you filtered the ones for the imported code. That's OK for > most symbols if they are not relevant for the part where you work on. But > Chris > copied a whole block of "extern struct usb_temp_device_desc *". It's not clear > for me whether you filtered some of them or whether they haven't been > generated. > > If they are generated: Please keep them. Basically keep everything that is in > one of the files that you touch, except if you have a good reason why the > symbol > should _not_ be added. > > If they are not generated: Please clearly say that. >
The issue is the merging against my changes and as I have stated in the other thread I have replaced the change script because it on worked on Linux plus the sort order was something I could not match on other host platforms. My changes address the sort order, tools used and I added the few symbols that must have been missed over a period of time. That happens. I hope the updated procedure is simpler and safer to use on any host platform we support. Chris _______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel