On Sun, Jan 11, 2004 at 07:26:04AM -0500, Jonathan Thambidurai wrote: >On Sat, 2004-01-10 at 23:25, David Dawes wrote: > >> The 24-bit flags argument to xf86SetDepthBpp() should probably >> be: >> >> Support24bppFb | Support32bppFb | SupportConvert32to24 | PreferConvert32to24 >> >> Since the actual framebuffer format is passed explicitly, this should >> be safe in all cases. It will then default to using 32-bit bpp for >> depth 24 pixmaps. It is possible that this change will fix the rotation >> problem you are seeing at 24-bit. >> >> It would be better to disable randr only when rotation is enabled. >> Have you tried adding it to the else part of the following: >> >> if (!fPtr->rotate) >> FBDevDGAInit(pScrn, pScreen); >> else { >> xf86DrvMsg(scrnIndex, X_INFO, "Rotated display, disabling DGA\n"); >> >> if (pScrn->bitsPerPixel == 24) >> xf86DrvMsg(scrnIndex, X_WARNING, "Rotation might be broken in 24 bpp >> \n"); >> } > >Applying the changes as you suggested, I have the attached diff. While >this allows correct rotation and (unrotated) 24 bpp, rotated 24 bpp is >still corrupt.
OK, I guess the generic shadow code doesn't support the packed 24bpp format? I'll apply your patch -- thanks. David -- David Dawes developer/release engineer The XFree86 Project www.XFree86.org/~dawes _______________________________________________ Devel mailing list [EMAIL PROTECTED] http://XFree86.Org/mailman/listinfo/devel