This adds a check for zc_nvlist_dst_filled prior to calling 
zcmd_read_dst_nvlist() which will cause the zfs command to exit with "internal 
error: out of memory" if the error list is not filled, which is the case when 
attempting to modify a property on a readonly pool.

It also fixes a slight mistake in the code where "errorprop" was fetched from 
the command buffer but "nvl" was used instead when making calls to 
zfs_setprop_error().
You can view, comment on, or merge this pull request online at:

  https://github.com/openzfs/openzfs/pull/654

-- Commit Summary --

  * 9616 Bogus error when attempting to set property on read-only pool

-- File Changes --

    M usr/src/lib/libzfs/common/libzfs_dataset.c (10)

-- Patch Links --

https://github.com/openzfs/openzfs/pull/654.patch
https://github.com/openzfs/openzfs/pull/654.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/654

------------------------------------------
openzfs: openzfs-developer
Permalink: 
https://openzfs.topicbox.com/groups/developer/Tc686962be780d038-M57754fcaece9db2a669db3b2
Delivery options: https://openzfs.topicbox.com/groups

Reply via email to