andy-js commented on this pull request.


> @@ -1808,13 +1808,17 @@ zfs_prop_set_list(zfs_handle_t *zhp, nvlist_t *props)
        ret = zfs_ioctl(hdl, ZFS_IOC_SET_PROP, &zc);
 
        if (ret != 0) {
+               (void) zfs_standard_error(hdl, errno, errbuf);

Oh.  You're right.  I didn't realise zfs_standard_error was actually printing 
stuff out.  I chose to do it this way because I thought it would handle the 
case where "errorprops" comes back empty, but I don't know if that's something 
that'll actually happen.  I'll have another go.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/654#discussion_r198839823
------------------------------------------
openzfs: openzfs-developer
Permalink: 
https://openzfs.topicbox.com/groups/developer/Tb4c6684d9add7dfe-Mfa9e85476025c5f74e6f3f20
Delivery options: https://openzfs.topicbox.com/groups

Reply via email to