On Mon, 25 Mar 2019 at 10:53, Gregor Kopka <[email protected]> wrote: > Looks good. > > Only thing: please make this feature lookup the features for a set from a > plain text file (like in /etc/zfs/), just containing > features_name = comma, separated, list, of, feature, names > and not something compiled in. > It should be easy to define custom feature sets, this would allow to do it > with ease.
It seems fine, perhaps, to allow _additional_ feature sets this way, but I think the "portable" family really needs to be something compiled in. The core value proposition is that "zpool create -o features=portable-2016" is the same _everywhere_, and allowing it to be easily overridden seems likely to erode that value. Cheers. -- Joshua M. Clulow Engineer @ Joyent http://blog.sysmgr.org ------------------------------------------ openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/Td66d70a086ae5a9e-M60c3fe3833a7ef129a47aaad Delivery options: https://openzfs.topicbox.com/groups/developer/subscription
