I'm not usually in favor of limiting configurability, but in this
case, I agree with Joshua - letting people add their own custom
defines for e.g. debian-buster or epel6 or ubuntu1604 might be fine
(though at that point I'd still like something like a constraint
solver to say "I want this to work on platforms X, Y, and Z" and have
it DTRT, but if nobody else agrees that's probably overkill :P), but
probably not a good plan to allow overriding portable{,-[0-9]+}, lest
people be allowed to override what the consistent names mean and
defeat the purpose.(I'm also torn because I somewhat feel like allowing overriding a subset of symbols might result in the same kind of problem, where e.g. every distro using ZoL 0.8 de facto ships a set of additional defines, but installing from source or running on e.g. illumos could result in inconsistent outcomes. But it's unclear how academic this fear is, and having some of the functionality is probably strictly better...) On Mon, Mar 25, 2019 at 7:02 PM Joshua M. Clulow <[email protected]> wrote: > > On Mon, 25 Mar 2019 at 10:53, Gregor Kopka > <[email protected]> wrote: > > Looks good. > > > > Only thing: please make this feature lookup the features for a set from a > > plain text file (like in /etc/zfs/), just containing > > features_name = comma, separated, list, of, feature, names > > and not something compiled in. > > It should be easy to define custom feature sets, this would allow to do it > > with ease. > > It seems fine, perhaps, to allow _additional_ feature sets this way, > but I think the "portable" family really needs to be something > compiled in. The core value proposition is that "zpool create -o > features=portable-2016" is the same _everywhere_, and allowing it to > be easily overridden seems likely to erode that value. > > Cheers. > > -- > Joshua M. Clulow > Engineer @ Joyent > http://blog.sysmgr.org ------------------------------------------ openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/Td66d70a086ae5a9e-Mf7db6801777e708749b8efd9 Delivery options: https://openzfs.topicbox.com/groups/developer/subscription
