> +     sa_buf_rele(db, FTAG);
> +
> +     if (dump_opt['v'] > 6)
> +             fprintf(stderr, "%s: obj %lu name '%s' type %d bonustype %d\n",
> +                 __func__, obj, name, doi.doi_type, doi.doi_bonus_type);
> +
> +     if (doi.doi_bonus_type != DMU_OT_SA &&
> +         doi.doi_bonus_type != DMU_OT_ZNODE) {
> +             fprintf(stderr, "Invalid bonus type %d for obj %lu!\n",
> +                 doi.doi_bonus_type, obj);
> +             return (EINVAL);
> +     }
> +
> +     switch (doi.doi_type) {
> +     case DMU_OT_PLAIN_FILE_CONTENTS:
> +             ASSERT3P(slash, ==, NULL);

Not a very nice way to communicate a user error (imagine `zdb -o file pool/fs 
/dir/file/impossible"`, but I guess this is just zdb :-\

---
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/29/files#r43468970
_______________________________________________
developer mailing list
developer@open-zfs.org
http://lists.open-zfs.org/mailman/listinfo/developer

Reply via email to