I could do that, if that is what the community wants (it would take only a few minutes). However, the comment at the top of the file says: "Currently, the interface is Evolving (not Committed), but we intend to commit to it once it is more complete and we determine that it meets the needs of all consumers." It seems to me that either the we are committed enough to the interface that we should remove that note or we should make changes to it now while it is still "evolving".
On Wed, May 18, 2016 at 5:39 PM, Richard Laager <rlaa...@wiktel.com> wrote: > On 05/17/2016 04:17 PM, Thomas Caputi wrote: >> >> I altered the prototype of lzc_create() and lzc_clone(). I understand >> that the purpose of libzfs_core is to have a stable api interacting >> with the ZFS ioctls. However, these functions need to accept wrapping >> keys separately from the rest of their parameters because they need to >> use the (new) hidden_args framework to support hiding arguments from >> the logs. Without this, the wrapping keys would get printed to the >> zpool history. > > > If you absolutely need to add another argument, then you could create a new > function (with whatever name, let's say lzc_create_with_hidden() for the > sake of this discussion). Then make lzc_create() call > lzc_create_with_hidden(). > > Then you're only adding API/ABI, so it's a minor version bump instead of a > major version bump. > > -- > Richard ------------------------------------------- openzfs-developer Archives: https://www.listbox.com/member/archive/274414/=now RSS Feed: https://www.listbox.com/member/archive/rss/274414/28015062-cce53afa Modify Your Subscription: https://www.listbox.com/member/?member_id=28015062&id_secret=28015062-f966d51c Powered by Listbox: http://www.listbox.com
