Eduard Witteveen wrote: >>Shouldn't this be a Hack? > > First i assume the MMC is speaking here?
No, just my personal opinion. The point here is: - You change behavior - You change the configuration so that results of queries may be different from what they normally return (even though I would call it a change for the better), so it's Hack. - It's not a bugfix - It's not part of a project. So it's Hack. You can check it in so people can test/check it out, but you do need to ask support for teh Hack. You also need to provide documentation, no matter how simple and logical the change and config may seem to you. Note: The MMC is not some kind of police, people. WE are just developers like you all, we do not have more 'power' - though we do have a responsibility to guard against code that might caus eproblems or conflicts. Judging what is a hack and what is not may sometimes be a bit difficult, but in general, if it change behavior (ratehr tahn a bugfix), and is not part of a project, then it's a Hack. > - Message node that has been removed This did not change behavior, but removed code that was obsolete and possibly migth cause conflicts. It was noticed during the MMCI1.2 (development of Node) that this is a problem, though the change falls under the Cleaning project. > - change of web.xml I feel this is part of teh distro project, or otherwise should be dealt with when the 1.6 release is created. > - added postgresql72 support Actually, you should, though I doubt people will resist additional database support. > - complete rewrite of connection pool IIRC, that was a Hack and people voted on it. If not, that should have happened. > - wizards xml's are validated This is part of the (still open) Editwizard project, so not a Hack. > If i would make a hack proposal about everything that changes, we would > have a lot of hack proposals(to much imho)... I think we DO need to make more Hack proposals, but I also think we need a better way to make those proposals - i.e. in bugtracker form on the site, with documentation, links, a forum for adding comments , etcetera. -- Pierre van Rooden Mediapark, C 107 tel. +31 (0)35 6772815 "So long, and thanks for all the fish"
