Eduard Witteveen <[EMAIL PROTECTED]> wrote:
> I want to add an optional property for builders.
> This propery is called 'max-search-results'.
> 
> The behaviour of this propery is that it stops creating new nodes after
> if the count get above the limit specified inside the builder.xml
> (default will be 0 and means no limit)


I think we can take it for granted that you can of course put this property
in object.xml to speficy a 'general' value.


> ReadSearchResults(ResultSet) will be changed, to ignore the records that
> are still left inside the resultset. 
> 
> Point of discussion could be, what should happen:
> - throw an exception
> - continue with these records.
>
> Personally i think that throwing an exception would be the best thing,
> since we have to notify the user that the query is 'invalid'

I'm not sure. Throwing exception will also destroy the valid results.
Generally I'm against exceptions while creating lists, because an error in
one entry (in this case the last onces), will fail the whole list. I would
support cutting the list and logging a big error (log.error, or even
log.fatal, the administrator should then contact the user...). But it is not
a big issue for me. I'll be +1 for any implementation of this.



Michiel


-- 
Michiel Meeuwissen 
Mediapark, C 107 tel. +31 (0)35 6772979



Reply via email to