Re: Compressing network traffic with orion/tomcat with new filter

[Gerard van Enk]

Marcel Maatkamp wrote:

On Wednesday 13 November 2002 21:42, Johannes Verelst wrote:

On Wed, 2002-11-13 at 21:12, Marcel Maatkamp wrote:

Hi all..

I have added a new directory 'org.mmbase.servlet.filter' with a few files
for quickly defining new filters. I have also added 'GZipFilter.java'
which can be chained between filters and will gzip the incoming request
and send it clientside if it is defined as the last filter.

While I really like the idea of this filter, I wonder why it was
instantly checked in without a 'bugfix' or a 'hack' note. We are
currently in a code-freeze, for which the release manager clearly
stated:

"Today is the start of the codefreeze, no more new features may be added
to cvs and only bugfixes may be checked in."

I have absolutely nothing against the code, but I wonder if it's wise to
check in new (experimental) code during a code-freeze before a new
release. Wouldn't it be better to postpone the check-in until after the
release?

Johannes

Hm the reason I've checked it in is that it has no core-functionality since
it is new and has to be enabled by adding it explicitly in web.xml. Maybe
you are right about a note of being a 'hack' but the definition of a hack
in my world is 'changing old code' instead of new.

The mmbaseguidelines <http://www.mmbase.org/mmbasenews/index2.shtml?about+3889> give the following definition of a hack:

"Code that was written outside of an approved project and is not a bug-fix"

But if the release states no new code, I remove it from cvs (you know how to find it) untill the 1.6 release is out.

You only have to wait until the branch has been created and this will happen next friday.

Gerard