Re: Compressing network traffic with orion/tomcat with new filter

[Gerard van Enk]

Johannes Verelst wrote:

On Wed, 2002-11-13 at 21:12, Marcel Maatkamp wrote:

Hi all..

I have added a new directory 'org.mmbase.servlet.filter' with a few files for quickly defining new filters. I have also added 'GZipFilter.java' which can be chained between filters and will gzip the incoming request and send it clientside if it is defined as the last filter.

While I really like the idea of this filter, I wonder why it was
instantly checked in without a 'bugfix' or a 'hack' note. We are
currently in a code-freeze, for which the release manager clearly
stated:

"Today is the start of the codefreeze, no more new features may be added
to cvs and only bugfixes may be checked in."

I have absolutely nothing against the code, but I wonder if it's wise to
check in new (experimental) code during a code-freeze before a new
release. Wouldn't it be better to postpone the check-in until after the
release?

Johannes beats me.....but I totally agree. This is not allowed during the code freeze and I think this must be a hack, so it must be voted about. Most people will like this filter and the vote probably will be positive, but will you please remove you're code and cast a vote?

If you like to let other people take a look at the code you could check it in the 'speeltuin' cvs module.

Gerard