Pierre van Rooden wrote: > Michiel Meeuwissen wrote: > >Speaking of inner classes, there is one 'inner' class present in the code, > >which I've put there only > >for convenience (EncodingDetectingOutputStreamWriter), this will of course > >become a stand alone > >class. > > I personally find EncodingDetectingOutputStreamWriter a tad long for a > class. Matter of taste, but I prefer classnames I can pronoucne without > trippin over my tongue. > I suggest to just call it "EncodedWriter" and have it function like > BufferedWriter.
I don't really care. It is actually used excactly like 'OutputStreamWriter', the only differnce being that you don't need to specify an encoding. That's why I supposed that ending the class-name with 'OutputStreamWriter' would be desirable. Anyhow, I think my class-name is more descriptive than yours but it is longer, indeed :-) How about 'EncodingDetectingWriter', because a writer is always encoded and therefore 'EncodedWriter' is a bit pleonastic. The essence is there, that it (tries to) detect(s) the encoding. Actually, it does only anything intelligent if it sees that is is XML (the same trick was used on more places e.g. in mm:include) already. 'XMLOutputStreamWriter'? Michiel -- Michiel Meeuwissen mihxil' Mediacentrum 140 H'sum [] () +31 (0)35 6772979 nl_NL eo_XX en_US
