Hi, Any webpage contains a lot of images, I am not aware of the time complexity of the function implementation, but won't it will be an overkill to generate so many md5 hashes?
Looking forward. Message: 1 Date: Mon, 14 Sep 2009 21:16:12 +0530 From: nitin gupta <[email protected]> Subject: [development] Shortening file names downloaded from webpage To: [email protected] Message-ID: <[email protected]> Content-Type: text/plain; charset="iso-8859-1" Hello, I am maintaining a module FeedAPI ImageGrabber. It downloads a relevant image from a webpage of the feed-item and stores it along with the node. I found that the module sometimes gave the 'filename too long error' ( http://drupal.org/node/505964). It happens because I was saving the image file with the name as basename($image_url). But to solve the issue, I am now trying this code to shorten the filename. $arr = parse_url($image_url); $filename = basename($arr['path']); This code solves the problem by removing the query and fragments of the url. Does anyone know of any better way to handle this? Can anyone point out any issues with this code? Regards, Nitin Kumar Gupta http://publicmind.in/blog -------------- next part -------------- An HTML attachment was scrubbed... URL: < http://lists.drupal.org/pipermail/development/attachments/20090914/1269e63c/attachment-0001.htm > ------------------------------ Message: 2 Date: Mon, 14 Sep 2009 17:12:40 +0100 From: Stewart Robinson <[email protected]> Subject: Re: [development] Shortening file names downloaded from webpage To: [email protected] Message-ID: <[email protected]> Content-Type: text/plain; charset="iso-8859-1" Why not just md5() the full URL and store that instead. i.e. $filename = md5($arr['path']); -- Regards, Nitin Kumar Gupta http://publicmind.in/blog
