If uniqueness is an issue, http://us2.php.net/manual/en/function.md5-file.php may be good in conjunction with a sanitized file name.

For one site with public uploads, I use [sanitized and shortened file name]-[md5 of file].[ext], which ensures duplicate files will overwrite each other but otherwise you don't have to really worry about the file names being unique.

Using [md5 of file].[ext] only means much less helpful file names when downloaded and a much larger (but still small) chance of collisions.

- Ken Winters

Stewart Robinson wrote:
I believe the problem Nitin had was around long file names and that approach doesn't guarantee a file name that is within a certain length, where as the md5 does. I agree that his approach using those two lines is a nicer cleaner approach if you don't have to worry about file name length.

Stew

2009/9/15 Earnie Boyd <[email protected] <mailto:[email protected]>>

    Quoting nitin gupta <[email protected]
    <mailto:[email protected]>>:


        $arr = parse_url($image_url);
        $filename = basename($arr['path']);

        This code solves the problem by removing the query and
        fragments of the url.
        Does anyone know of any better way to handle this? Can anyone
        point out any
        issues with this code?


    I think this is the better way.  I don't find anything in the
    Drupal API to help.

    --
    Earnie
    -- http://r-feed.com/           -- http://for-my-kids.com/
    -- http://www.4offer.biz/       -- http://give-me-an-offer.com/



Reply via email to