Stephen Kelly said: > On Wednesday, November 09, 2011 13:54:37 Thiago Macieira wrote: > > On Friday, 28 de October de 2011 12:38:38 lars.kn...@nokia.com wrote: > > > We've been moving this lib quite a bit already. If we move it again, I'd > > > prefer it would end up at it's final location. The move was done before > > > we had the decision to keep QtCore independent of V8 and to separate > > > the QJS* classes and the QML engine into it's own module. > > > > > > With the above decision it might make sense to move V8, the QJS* classes > > > and the QML engine all into the same shared library. > > > > > > Kent & Aaron, any thoughts? > > > > Since they don't seem to have an opinion, can we please move it to top-level > > inside qt5.git? > > > > I've just caught a bad commit in my tree that updates the commit link to v8 > > and I'm trying to fix it with an interactive rebase. > > Bump. This is a recurring problem with newcomers trying to build qtbase. They > don't know to do the git submodule magic or use -no-v8, so the build fails. >
I think this can be easily mitigated by having qmake check if the sources exist, rather than simply assuming that they do. e.g. http://codereview.qt-project.org/10934 . _______________________________________________ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development