Hi,

On 12/12/2011, at 2:15 PM, ext shane.kea...@accenture.com wrote:

>> This would help a bit for one problem.
>> 
>> But the other problem is that it makes working with qtbase harder
>> because of
>> the submodule. (while comitting you have to remember not to commit the
>> v8
>> stuff)
>> 
>> I think having a submodule in qtbase causes a lot of trouble for very
>> little
>> gain.
>> 
> 
> Another issue is that the V8 repository has files checked in with CRLF line 
> endings (intentionally or otherwise), which makes git think there is always a 
> modified file if core.autocrlf=true in git config.
> Among other things, this blocks the "git submodule update"
> 
> It can be worked around like this:
> 
> $ git submodule update
> error: You have local changes to 'tools/visual_studio/d8_arm.vcproj'; cannot 
> switch branches.
> Unable to checkout 'd28b6a024826aaa48a8b3e69c096d01c91aff2c9' in submodule 
> path'src/3rdparty/v8'
> 
> $ cd src/3rdparty/v8/
> 
> $ git reset --hard d28b6a024826aaa48a8b3e69c096d01c91aff2c9
> Checking out files: 100% (894/894), done.
> HEAD is now at d28b6a0 Add flag to avoid breakpoint relocation

The Qt v8 repo is a clone of the official v8 git repo, so we preserve whatever 
formatting Google has chosen.

Cheers,

Aaron


> 
> ________________________________
> Subject to local law, communications with Accenture and its affiliates 
> including telephone calls and emails (including content), may be monitored by 
> our systems for the purposes of security and the assessment of internal 
> compliance with Accenture policy.
> ______________________________________________________________________________________
> 
> www.accenture.com
> 
> _______________________________________________
> Development mailing list
> Development@qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development

_______________________________________________
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Reply via email to