On segunda-feira, 16 de abril de 2012 00.08.43, Olivier Goffart wrote: > On Saturday 14 April 2012 20:06:53 Giuseppe D'Angelo wrote: > > So, after *too many* commits[1] -- QHash randomization was merged a > > few hours ago! > > > > https://qt.gitorious.org/qt/qtbase/commit/c01eaa438200edc9a3bbcd8ae1e8ded0 > > 58 bea268 > > > > Thanks to all of the guys involved for the ideas, feedback, reviewing > > the patches... and staging them :-) > > Nice work! > > I'm just not really happy with the fact that you removed the optimisation > for int to avoid storing both the hash and the key.
It was stored as the same field because hash and key were the same.
if you salt the hash, it's no longer the same. Therefore, they can't share a
field.
> You can't put it back in Qt 5.x because it is not binary compatible.
> Did you really not find a way to fix it? (i.e: not storing the hash for
> Primitive types.)
Suggestions welcome.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
