On 02/05/2013 02:15 PM, David Faure wrote: > . > Looking at the patch with git diff origin/dev...origin/wip/android > [not very convenient for commenting on code changes...] > > I see changes that are unrelated to android:
I've tried to separate the non-android-specific changes we inherited from Necessitas out into separate commits that I will submit to dev ahead of time and get proper reviews as soon as possible, as I think we will might have to go a few rounds with some of them before they can be approved. Currently I have them as WIPs in Gerrit, because I'm waiting for help to understand what each of them are doing. Once I do, I will update the commit messages and add relevant people as reviewers for them. Here's a list of the changes in question (you could also filter on my name and look for anything starting with WIP:). The commit messages are place holders at the moment, but if maintainers want to look at them already, then I would glad to have feedback as soon as possible: https://codereview.qt-project.org/#change,46789 https://codereview.qt-project.org/#change,46790 https://codereview.qt-project.org/#change,46791 https://codereview.qt-project.org/#change,46792 https://codereview.qt-project.org/#change,46793 https://codereview.qt-project.org/#change,46794 (this is also missing documentation) https://codereview.qt-project.org/#change,46795 https://codereview.qt-project.org/#change,46796 https://codereview.qt-project.org/#change,46797 https://codereview.qt-project.org/#change,46798 https://codereview.qt-project.org/#change,46800 https://codereview.qt-project.org/#change,46801 https://codereview.qt-project.org/#change,46802 https://codereview.qt-project.org/#change,46803 https://codereview.qt-project.org/#change,46804 https://codereview.qt-project.org/#change,46805 https://codereview.qt-project.org/#change,46806 > --- a/src/gui/kernel/qplatforminputcontext.cpp > +++ b/src/gui/kernel/qplatforminputcontext.cpp > @@ -114,7 +114,7 @@ void QPlatformInputContext::commit() > /*! > Notification on editor updates. Called by QInputMethod::update(). > */ > -void QPlatformInputContext::update(Qt::InputMethodQueries) > +void QPlatformInputContext::update(Qt::InputMethodQueries queries) > { > } > > Well, this is just bogus, it creates a compiler warning. I'll remove stuff like this from the initial commit before submitting it to dev. -- Eskil _______________________________________________ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
