Hi, Yes, the copy constructor is used. The change was introduced to calm down MSVC in paranoia mode, apparently it complains about usage of a default copy constructor if an assign operator is also defined by the compiler but not used, or something ridiculous like that.
https://codereview.qt-project.org/#change,83978 Cheers, Jędrek ________________________________________ From: development-bounces+jedrzej.nowacki=digia....@qt-project.org [development-bounces+jedrzej.nowacki=digia....@qt-project.org] on behalf of Thiago Macieira [thiago.macie...@intel.com] Sent: Wednesday, April 23, 2014 01:34 To: development@qt-project.org Subject: Re: [Development] Qt 5.3 header diff: QtCore No major issues. All cosmetic. Em ter 22 abr 2014, às 14:12:46, Thiago Macieira escreveu: > --- a/src/corelib/kernel/qmetatype.h > +++ b/src/corelib/kernel/qmetatype.h > @@ -771,9 +771,13 @@ struct VariantData > , flags(flags_) > { > } > + VariantData(const VariantData &other) > + : metaTypeId(other.metaTypeId), data(other.data), > flags(other.flags){} const int metaTypeId; > const void *data; > const uint flags; > +private: > + VariantData &operator=(const VariantData &) Q_DECL_EQ_DELETE; > }; Is copy construction intended here? If so, please add a comment. If not, please use Q_DISABLE_COPY. _______________________________________________ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development