I agree with Simon and Mark. Volume is a term that IMO will confuse most people in this context. Storage sounds a lot better to me as well. Can we please fix that? And a name change of course doesn’t block it from 5.4 :)
Cheers, Lars On 10/08/14 11:31, "Mark Gaiser" <mark...@gmail.com> wrote: >On Sat, Aug 9, 2014 at 10:39 PM, Hausmann Simon ><simon.hausm...@digia.com> wrote: >> Hi, >> >> I sincerely hope that the class name will be reconsidered, given how >>generic and therefore ambiguous the term volume is. Please consider >>making it more specific by adding Storage or something else to the name >>and avoid that people guess wrongly and avoid people finding this class >>when they search for the audio volume api elsewhere in Qt. Pretty please >>with a cherry :) > >First thing i though when seeing the "QVolumeInfo" name was: >"Oh cool, so this abstracts the _sound_ volume information between >windows/mac/linux." >Which it's not. > >The first thing one associates "volume" with is sound, not mounted >volumes hence the current name is ambiguous. > >QStorageInfo would be a much better fit imho. >> >> >> Simon >> >> Opprinnelig melding >> Fra: Иван Комиссаров >> Sendt: 11:24 lørdag 9. august 2014 >> Til: Buddenhagen Oswald >> Kopi: development@qt-project.org; releas...@qt-project.org >> Emne: Re: [Development] HEADS UP: Qt 5.4 feature freeze - is frozen now >> >> >> Thank you for notification. Please, re-rarget QVolumeInfo to 5.4 branch >>(https://codereview.qt-project.org/#/c/73945/78). >> And review patchset 78, someone:) >> >> Иван Комиссаров >> >> 09 авг. 2014 г., в 12:16, Iikka Eklund (via Oswald Buddenhagen) >><oswald.buddenha...@digia.com> написал(а): >> >>> Hi, >>> >>> the ‘dev’ branch is now temporarily closed. From now on, all changes >>> targeted to Qt5.4.0 need to be pushed to ‘5.4’ branch (once available). >>> >>> Note that Ossi will continue re-staging changes on dev that fail to >>> integrate for no fault of their own, until some reasonable deadline. >>> >>> We will inform you when the ‘5.4’ branch is available and when ‘dev’ >>> branch is opened for changes for Qt5.5.0. >>> >>> Changes intended for 5.4 which were already pushed for dev can be >>> re-targeted server-side by administrative action without abandoning and >>> re-pushing. Drop Ossi a line. >>> >>> Fixes for 5.3, especially those already uploaded, should NOT be >>> re-targeted to 5.4 - 5.3 will be merged to 5.4 for weeks to come. >>> >>> -- Iikka >>> -- (edited & sent by Ossi) >>> >>> On 07/29/2014 11:20 AM, Heikkinen Jani wrote: >>>> Hi, >>>> >>>> Please remember: Qt 5.4 feature freeze is Friday 8th August 2014 12:00 >>>> CET. It means: >>>> >>>> -‘Dev’ branch will be temporarily locked 8th August 2014 12:00 CET >>>> >>>> oAfter that time any changes that are required for Qt 5.4.0 needs to >>>>be >>>> pushed to the '5.4' branch. So if your changes are not in by that >>>>time, >>>> please wait until the branching is done and re-target it to the '5.4' >>>> branch. >>>> >>>> -All new features/modules targeted to Qt 5.4 must be in ‘dev’ –branch >>>>at >>>> that time & must fulfill criteria for new features/modules (from >>>>Lars’s >>>> old email): >>>> >>>> oPlease make sure that all new functionality >>>> >>>> §Compiles on all reference platforms >>>> >>>> · (If a module/feature is only for one platform, make sure qmake/make >>>> does nothing on the other platforms) >>>> >>>> §Have tests >>>> >>>> ·Automated tests should cover as much as possible of the new >>>> functionality. If certain areas are not covered by automated tests, >>>>I'd >>>> like to hear how testing will be done for those >>>> >>>> §Have documentation >>>> >>>> · No undocumented public API. Basic docs have to be there, only >>>> polishing should still be required after the freeze >>>> >>>> §Have examples >>>> >>>> ·Have some examples showing how to use the API. Examples need to be >>>> linked from documentation. >>>> >>>> oIn addition, new modules need to >>>> >>>> §Follow the branching scheme >>>> >>>> ·A new module can be ok to only have dev, with ‘5.4’ being created at >>>> branching time. >>>> >>>> oHave a CI system >>>> >>>> §New modules that are going to be part of Qt releases need to have a >>>>CI >>>> system set up. Please contact CI team early enough…. >>>> >>>> -Each new module needs to be a part of qt5.git already in ‘dev’ >>>>branch. >>>> Please notify release team about any new module for Qt 5.4 >>>>immediately! >>>> >>>> -‘5.4’ will be branched from ‘dev’ Mon 11^th August 2014 >>>> >>>> Br, >>>> >>>> Jani >>>> >>>> >>>> >>>> _______________________________________________ >>>> Development mailing list >>>> Development@qt-project.org >>>> http://lists.qt-project.org/mailman/listinfo/development >>>> >>> >>> >>> -- >>> Br, >>> Mr. Iikka Eklund >>> Senior software engineer >>> >>> Elektronikkatie 10 >>> FI-90590 Oulu >>> Email: iikka.ekl...@digia.com >>> >>> Visit us at: www.digia.com or qt.digia.com >>> ------------------------------------------------------------------ >>> PRIVACY AND CONFIDENTIALITY NOTICE >>> This message and any attachments are intended only for use by the named >>> addressee and may contain privileged and/or confidential information. >>>If >>> you are not the named addressee you should not disseminate, copy or >>>take >>> any action in reliance on it. If you have received this message in >>> error, please contact the sender immediately and delete the message and >>> any attachments accompanying it. Digia Plc does not accept liability >>>for >>> any corruption, interception, amendment, tampering or viruses occurring >>> to this message. >>> ------------------------------------------------------------------ >>> _______________________________________________ >>> Development mailing list >>> Development@qt-project.org >>> http://lists.qt-project.org/mailman/listinfo/development >>> >> _______________________________________________ >> Development mailing list >> Development@qt-project.org >> http://lists.qt-project.org/mailman/listinfo/development >> _______________________________________________ >> Development mailing list >> Development@qt-project.org >> http://lists.qt-project.org/mailman/listinfo/development >_______________________________________________ >Development mailing list >Development@qt-project.org >http://lists.qt-project.org/mailman/listinfo/development _______________________________________________ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development