On Friday 26 September 2014 13:33:55 Giulio Camuffo wrote:
> Uhm, how did you get that number? A "git log -n 200 |grep Andy|wc -l"
> says 5 to me, four Reviewed-by and one Author, the last one being on
> February 11.
> I don't want to be dismissive of the work he has done on qtwayland,
> but he hasn't been working on it for many months, and on and off for
> even more. Jørgen or Laszlo would be a better fit, imho.

I ran this:

$ git log origin/5.4~200..origin/5.4 | grep Reviewed-by | sort | uniq -c
     32     Reviewed-by: Andrew Knight <andrew.kni...@digia.com>
    140     Reviewed-by: Andy Nichols <andy.nich...@digia.com>
      1     Reviewed-by: Elvis Lee <kwangwoong....@lge.com>
      1     Reviewed-by: Frederik Gladhorn <frederik.gladh...@digia.com>
      3     Reviewed-by: Giulio Camuffo <giuliocamu...@gmail.com>
     50     Reviewed-by: Giulio Camuffo <giulio.camu...@jollamobile.com>
      2     Reviewed-by: Gunnar Sletta <gunnar.sle...@digia.com>
     34     Reviewed-by: Gunnar Sletta <gunnar.sle...@jollamobile.com>
      1     Reviewed-by: Gunnar Sletta <gun...@sletta.org>
     36     Reviewed-by: Jan Arne Petersen <jan.peter...@kdab.com>
      1     Reviewed-by: Jędrzej Nowacki <jedrzej.nowa...@digia.com>
      2     Reviewed-by: Joerg Bornemann <joerg.bornem...@digia.com>
    109     Reviewed-by: Jørgen Lind <jorgen.l...@digia.com>
      8     Reviewed-by: Jørgen Lind <jorgen.l...@gmail.com>
     89     Reviewed-by: Laszlo Agocs <laszlo.ag...@digia.com>
      1     Reviewed-by: Laszlo Papp <lp...@kde.org>
      1     Reviewed-by: Lubomir Rintel <lkund...@v3.sk>
      1     Reviewed-by: Michael Brasser <michael.bras...@live.com>
      2     Reviewed-by: Mikko Levonmaa <mikko.levon...@lge.com>
      6     Reviewed-by: Oswald Buddenhagen <oswald.buddenha...@digia.com>
      7     Reviewed-by: Paul Olav Tvete <paul.tv...@digia.com>
      2     Reviewed-by: Philippe Coval <r...@gna.org>
     18     Reviewed-by: Pier Luigi Fiorini <pierluigi.fior...@gmail.com>
     26     Reviewed-by: Robin Burchell <robin.burch...@viroteck.net>
     30     Reviewed-by: Robin Burchell <robin...@viroteck.net>
     17     Reviewed-by: Samuel Rødal <samuel.ro...@digia.com>
      3     Reviewed-by: Sergio Ahumada <sahum...@blackberry.com>
      5     Reviewed-by: Shawn Rutledge <shawn.rutle...@digia.com>
      1     Reviewed-by: Simo Fält <simo.f...@digia.com>
      2     Reviewed-by: Thiago Macieira <thiago.macie...@intel.com>
      1     Reviewed-by: Tor Arne Vestbø <tor.arne.ves...@digia.com>
      1     Reviewed-by: Vesa Halttunen
      1     Reviewed-by: Yen-Chin Lee <coldnew...@gmail.com>

Problem: origin/5.4~200..origin/5.4 contains more than 200 commits due to 
merging. That's actually 491. I didn't notice this problem because the number 
of reviews per person were all less than 200. Bad coincidence.

If I restrict to actually 200 commits, here's the result:

$ git log -n200 origin/5.4 | grep Reviewed-by | sort | uniq -c          
      4     Reviewed-by: Andrew Knight <andrew.kni...@digia.com>
      4     Reviewed-by: Andy Nichols <andy.nich...@digia.com>
      1     Reviewed-by: Frederik Gladhorn <frederik.gladh...@digia.com>
      1     Reviewed-by: Giulio Camuffo <giuliocamu...@gmail.com>
     50     Reviewed-by: Giulio Camuffo <giulio.camu...@jollamobile.com>
     34     Reviewed-by: Gunnar Sletta <gunnar.sle...@jollamobile.com>
      1     Reviewed-by: Gunnar Sletta <gun...@sletta.org>
      2     Reviewed-by: Jan Arne Petersen <jan.peter...@kdab.com>
     22     Reviewed-by: Jørgen Lind <jorgen.l...@digia.com>
     48     Reviewed-by: Laszlo Agocs <laszlo.ag...@digia.com>
      1     Reviewed-by: Michael Brasser <michael.bras...@live.com>
      2     Reviewed-by: Mikko Levonmaa <mikko.levon...@lge.com>
      1     Reviewed-by: Oswald Buddenhagen <oswald.buddenha...@digia.com>
      2     Reviewed-by: Philippe Coval <r...@gna.org>
      6     Reviewed-by: Pier Luigi Fiorini <pierluigi.fior...@gmail.com>
     26     Reviewed-by: Robin Burchell <robin.burch...@viroteck.net>
     25     Reviewed-by: Robin Burchell <robin...@viroteck.net>
      1     Reviewed-by: Sergio Ahumada <sahum...@blackberry.com>
      5     Reviewed-by: Shawn Rutledge <shawn.rutle...@digia.com>
      1     Reviewed-by: Thiago Macieira <thiago.macie...@intel.com>
      1     Reviewed-by: Vesa Halttunen
      1     Reviewed-by: Yen-Chin Lee <coldnew...@gmail.com>

And you're right, the last time Andy reviewed anything in qtwayland was 
February/2014.

So, Andy, are you coming back? Or do you want to step down for someone else?

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

_______________________________________________
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Reply via email to