On Sunday 15 March 2015 19:28:22 André Pönitz wrote: > On Fri, Mar 13, 2015 at 12:41:32PM -0700, Thiago Macieira wrote: > > > Which can still be done in one line. But we don't even need to do it. > > > We > > > can leave the old one as it, and use Q_ASSERT_UNUSED for the new asserts > > > > Before we discuss the name, we have to discuss doing a 10k-line change to > > 1884 files in Qt. > > A semi-mechanical change of that size doesn't sound worse than a regular > license update.
It's not worse. It's just as bad. Neither type of change should have to happen. Peppe asked: > But why would such a change be necessary? Because we want to benefit from the new code and remove the unnecessary #ifndef and Q_UNUSED. If we don't change the current macro, then we deprecate the old one and convert all the code to the new one -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center _______________________________________________ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development