On Wed, Oct 10, 2012 at 10:35:01AM -0400, Matt Porter wrote: > On Wed, Oct 10, 2012 at 02:19:40PM +0000, Vaibhav Hiremath wrote: > > On Wed, Oct 10, 2012 at 19:30:27, Porter, Matt wrote: > > > On Tue, Oct 09, 2012 at 02:27:20PM +0530, Vaibhav Hiremath wrote: > > > > With recent changes in omap gpmc driver code, in case of DT > > > > boot mode, where bootloader does not configure gpmc cs space > > > > will result into kernel BUG() inside gpmc_mem_init() function, > > > > as gpmc cs0 gpmc_config7[0].csvalid bit is set to '1' and > > > > gpmc_config7[0].baseaddress is set to '0' on reset. > > > > > > > > This use-case is applicable for any board/EVM which doesn't have > > > > any peripheral connected to gpmc cs0, for example BeagleXM and > > > > BeagleBone, so DT boot mode fails. > > > > > > > > This patch adds of_have_populated_dt() check before creating > > > > device, so that for DT boot mode, gpmc probe will not be called > > > > which is expected behavior, as gpmc is not supported yet from DT. > > > > > > > > Signed-off-by: Vaibhav Hiremath <hvaib...@ti.com> > > > > Cc: Afzal Mohammed <af...@ti.com> > > > > Cc: Tony Lindgren <t...@atomide.com> > > > > Cc Paul Walmsley <p...@pwsan.com> > > > > --- > > > > This should go in for rc1, as this breaks AM33xx boot. > > > > > > Fixes BeagleBone on mainline. > > > > > > Tested-by: Matt Porter <mpor...@ti.com> > > > > > > > Thanks Matt and Afzal, > > > > Tony can this be picked up for rc1?? I know you have already sent pull > > request for rc1, but by any chance you are planning to send another request? > > I also found a separate problem with the mcasp clock data that's needed > for rc1. I just posted a patch for that as I need both this patch and the > clock data fix to boot from current mainline.
Disregard now that you got me pointed to the pull request with this :) -Matt _______________________________________________ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss