On Tue, Apr 23, 2013 at 03:13:18AM +0100, Tony Prisk wrote: > On 23/04/13 03:27, Lorenzo Pieralisi wrote: > > This patch updates the in-kernel dts files according to the latest cpus > > and cpu bindings updates for ARM. > > > > Signed-off-by: Lorenzo Pieralisi <lorenzo.pieral...@arm.com> > > --- > > arch/arm/boot/dts/wm8505.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/wm8505.dtsi b/arch/arm/boot/dts/wm8505.dtsi > > index e74a1c0..a470808 100644 > > --- a/arch/arm/boot/dts/wm8505.dtsi > > +++ b/arch/arm/boot/dts/wm8505.dtsi > > @@ -13,7 +13,7 @@ > > > > cpus { > > cpu@0 { > > - compatible = "arm,arm926ejs"; > > + compatible = "arm,arm926"; > > }; > > }; > > > As the only author for that file, and the arch-vt8500 maintainer, a CC > would have been nice :)
Apologies. > This binding is still incomplete.device_type, compatible and reg are all > required properties. device_type should already be there and I should not be in charge of adding it; reg is not required for that processor. > Also, you seem to have only fixed the wm8505.dtsi, while vt8500.dtsi, > wm8650.dtsi and wm8850.dtsi are all left incorrect. There is no cpus node in there. I can't add cpus node in all dts files in the kernel where it is missing (why have those dts files been accepted in the first place, with no cpus node ? why ? cpus node is mandatory since device tree was introduced, I really do not understand why those dts landed in the kernel as they are), I would kindly ask maintainers to do that, I just can not know what cpus are there for every given SoC. > I am already carrying a patch to fix all this properly so could you drop > the arch-vt8500 related patch and I will send in a more complete version > for 3.11 Good, thanks. Lorenzo _______________________________________________ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss