Hi, On Mon, Jun 24, 2013 at 11:01:56AM +0530, Kishon Vijay Abraham I wrote: > >>@@ -397,9 +407,10 @@ static int omap2430_musb_init(struct musb *musb) > >> if (glue->status != OMAP_MUSB_UNKNOWN) > >> omap_musb_set_mailbox(glue); > >> > >>- usb_phy_init(musb->xceiv); > >>+ phy_init(musb->phy); > >> > >> pm_runtime_put_noidle(musb->controller); > >>+ phy_pm_runtime_put(musb->phy); > > > >see, weird unbalanced calls :-) > > > >Make it all explicit: > > > >phy_pm_runtime_get_sync(phy); > >phy_init(phy); > >phy_pm_runtime_put(phy); > > I think then it makes sense to drop get_sync from phy_init()?
maybe not, you don't know if the phy has already autosuspended or not. -- balbi
signature.asc
Description: Digital signature
_______________________________________________ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss
