> > This patch adds the support for Device tree bindings of extcon-gpio driver. > The extcon-gpio device tree node must include the both 'extcon-id' and > 'extcon-gpio' property. > [] > > Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
Except for some beautification issues described below, Signed-off-by: MyungJoo Ham <myungjoo....@samsung.com> > --- > This patch is based on following patch[1]. > [1] https://lkml.org/lkml/2015/10/3/304 > > Changes from v1: > - Create the include/dt-bindings/extcon/extcon.h including the identification > of external connector. These definitions are used in dts file. > - Fix error if CONFIG_OF is disabled. > > .../devicetree/bindings/extcon/extcon-gpio.txt | 38 +++++++ > drivers/extcon/extcon-gpio.c | 110 > ++++++++++++++++----- > include/dt-bindings/extcon/extcon.h | 44 +++++++++ > include/linux/extcon/extcon-gpio.h | 6 +- > 4 files changed, 173 insertions(+), 25 deletions(-) > create mode 100644 Documentation/devicetree/bindings/extcon/extcon-gpio.txt > create mode 100644 include/dt-bindings/extcon/extcon.h > > diff --git a/Documentation/devicetree/bindings/extcon/extcon-gpio.txt > b/Documentation/devicetree/bindings/extcon/extcon-gpio.txt > new file mode 100644 > index 000000000000..70c36f729963 > --- /dev/null > +++ b/Documentation/devicetree/bindings/extcon/extcon-gpio.txt [] > diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c > index 279ff8f6637d..7f3e24aae0c4 100644 > --- a/drivers/extcon/extcon-gpio.c > +++ b/drivers/extcon/extcon-gpio.c > @@ -1,8 +1,8 @@ > /* > * extcon_gpio.c - Single-state GPIO extcon driver based on extcon class > * > - * Copyright (C) 2008 Google, Inc. > - * Author: Mike Lockwood <lockw...@android.com> > + * Copyright (C) 2015 Chanwoo Choi <cw00.c...@samsung.com>, Samsung > Electronics > + * Copyright (C) 2008 Mike Lockwood <lockw...@android.com>, Google, Inc. > * > * Modified by MyungJoo Ham <myungjoo....@samsung.com> to support extcon > * (originally switch class is supported) Let's make it in chronological order. (may need to "beautify the last two lines as well) I.e., 2008-->2012-->2015 or 2015-->2012-->2008. Not 2015-->2008-->2012 > @@ -26,12 +26,14 @@ [] > diff --git a/include/dt-bindings/extcon/extcon.h > b/include/dt-bindings/extcon/extcon.h > new file mode 100644 > index 000000000000..14c7f36b2206 > --- /dev/null > +++ b/include/dt-bindings/extcon/extcon.h [] > diff --git a/include/linux/extcon/extcon-gpio.h > b/include/linux/extcon/extcon-gpio.h > index 7cacafb78b09..bcc6d7f7116a 100644 > --- a/include/linux/extcon/extcon-gpio.h > +++ b/include/linux/extcon/extcon-gpio.h [] > @@ -38,7 +38,7 @@ struct gpio_extcon_pdata { > unsigned int extcon_id; > unsigned gpio; > bool gpio_active_low; > - unsigned long debounce; > + unsigned int debounce; What about u32, making it more clear? ( > + device_property_read_u32(dev, "debounce-ms", &pdata->debounce); ) > unsigned long irq_flags; > > bool check_on_resume; > -- > 1.8.0 N�����r��y����b�X��ǧv�^�){.n�+���z��z��z)����w* jg��� �����ݢj/���z�ޖ��2�ޙ����&�)ߡ�a���� �G���h��j:+v���w��٥
