On Mon, Sep 23, 2013 at 11:00:21AM -0700, leuchtkaefer wrote: > > Hello, > > Today is GSoC deadline. It was a great experience to participate on that > program, which give me the opportunity to start collaborating in a large open > source project. I want to thank toad for being my mentor and others members > of the community that helped me when I shout help on IRC, specially > openhiem1, digger3, xor and Bombe. > During the summer, I learned lot of things of Freenet that I included on my > code which has about 3500 lines. Curator plugin depends heavily on Web Of > Trust and Library. I did changes on Library to create and handle the multiple > indexes curator needs. > Curator is a plugin to create multiple catalogs of Freenet content. Content > can be web sites or any other document stored in Freenet. Such catalogs can > be added manually to the Search page and search content using Library. When a > user publishes a catalog, the FreenetURI is available in the identity page so > everyone can access to the identity. Curator has support to 3 languages: > English, German and Spanish. > The next big step will be to have distributed search of all indexes. Right > now, the workaround is to manually search the index as explained above. I > know the code has opportunities for improvement. I am willing to continue > collaborating with Freenet for adding more functionality to Curator plugin > and maybe programming other stuff.
That would be great! That would achieve the original objective of the GSoC project. However see below as well. > All the code is available in my github account. > Best, > Leuchtkaefer Thanks for your contributions! I hope to see this deployed in the not too distant future. There is quite a bit of work to do before that though. I may be able to do some of it. Nothing after 19:00 UTC contributes to your GSoC evaluation, so consider yourself a volunteer, free to do or not do whatever you want with Freenet; but if you want to help get this finished that would be great. Also bear in mind that I will have less time from Berlin (Saturday) onwards. People have often left in the past because of delays getting stuff deployed or merged. Lets try to make sure that doesn't happen this time. If you start on something and don't have time to finish it, please file a bug so that others can take it on. For now I have filed two bugs: https://bugs.freenetproject.org/view.php?id=6093 https://bugs.freenetproject.org/view.php?id=6094 You already have a few assigned to you regarding distributed search etc. Now, as I see it: Before merging the Library changes: - Somebody (other than the author, i.e. probably me but depends on who has time) needs to review the final diff. -- Review diffs to comparable code. - IdentityIndexUploader etc should take over from SpiderIndexUploader. That amount of duplicated code is very unhealthy. This will mean some small changes to Spider too. - Logging should use Logger, not System.* except in exceptional cases; I think most of this is done. - Probably cleanup the history. Before deploy contentcuration: - Somebody needs to re-review it (just the code). - Review diffs from comparable code (a lot of files are based on stuff elsewhere). - Rename to Curator. FYI brief review of last few commits to contentcuration: (This is not part of your SoC, feel free to ignore): 8c11efbb0f0fff1a115e915b7775674bce66fbf8 Don't use Vector, List<String> was better. I wouldn't use split() there, better substring, to avoid constraining index names. 7024e10a01ad2dc12816b1e83310d59ea5b3fccd - This should have been three commits. You should aim to do one thing in one commit. CurateForm: What's the issue with arabic/chinese? sort() will work fine, it won't be a locale specific sort, i.e. it won't be in the "natural" order, there is Collator for that, but is that a problem? Library: 3ce471fbcc3f1ed70385fdb829d8464e1add6b06 IdentityIndexURIs() should throw, because the URI is passed from the plugin, and might be bogus? Probably the caller could do the new FreenetURI(). If it's "impossible" then throw a RuntimeException like in IdentityIndexUploader. setParentDir(): You should check that the dir exists after mkdirs(). Ideally change the System.out.println()'s to Logger.error's, and get rid of the "LEUCHTKAEFER". Not vital though. This is merging changes from master as well as dealing with the folder per category code. 8391fd0228537c5501c4139e673f2ecdbae474d2 //TODO Leuchtkaefer do I need both if? Yes you do need both if's. 97b0b9cc3d38b2840fb5c432bb5b08a8b05f742c Why do we not need the edition? Will Library start inserting on startup if there is an unfinished insert in one of the indexes/categories on disk?
signature.asc
Description: Digital signature
_______________________________________________ Devl mailing list [email protected] https://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
